On Thu, Dec 15, 2022 at 11:34:06AM -0700, Logan Gunthorpe wrote: > On 2022-12-15 11:21, Bjorn Helgaas wrote: > > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > > Some switchtec_dev_read() error cases assign to "rc", then branch to "out". > > But the code at "out" never uses "rc". Drop the useless assignments. No > > functional change intended. > > Ah, hmm, yes. I think if copy_to_user() fails, the function should > probably return -EFAULT. So perhaps an unlock and specific return as is > done in previous conditions in the same function? Sure, I'll post a v2 that does that.
