On Wed, Nov 30, 2022 at 03:13:45PM -0700, Dave Jiang wrote: > Add AER error handler callback to read the correctable error status > register for the CXL device. Log the error as a trace event and clear the > error. For CXL devices, the driver also needs to write back to the AER CE > status register to clear the unmasked CEs. "AER CE status register" points in the wrong direction. > See CXL spec rev3.0 8.2.4.16 for Correctable Error Status Register. > static const struct pci_error_handlers cxl_error_handlers = { > .error_detected = cxl_error_detected, > .slot_reset = cxl_slot_reset, > .resume = cxl_error_resume, > + .cor_error_detected = cxl_correctable_error_logging, It makes grep/cscope a little more useful when the function name includes the struct member name, e.g., "cxl_cor_error_detected". Bjorn