On Tue, Nov 29, 2022 at 09:36:33AM -0700, Keith Busch wrote: > On Tue, Nov 29, 2022 at 08:35:55AM +0100, Lukas Wunner wrote: > > Add DPC Software Trigger as a reset method to be used for silicon > > validation among other things: > > Do you really need a kernel helper to do this? You can test these with > > # setpci -s <dsp's b:d.f> ECAP_DPC+6.w=40:40 > > And since the kernel is a not aware you are synthesizing the DPC event, > that more naturally tests how the kernel would react to a hardware dpc > trigger. I've seen people write a value directly instead of using the "data:mask" syntax above and that's dangerous because the register is under the control of the kernel. By exposing software trigger as a reset method I hope to make its invocation error-proof and more comfortable. Thanks, Lukas
