On Sun, Nov 27, 2022 at 04:10:05AM +0300, Serge Semin wrote: > On Wed, Nov 23, 2022 at 01:44:36PM -0600, Bjorn Helgaas wrote: > > On Sun, Nov 13, 2022 at 10:12:58PM +0300, Serge Semin wrote: > > Thanks for these new generic interfaces in the DWC core! And thanks > > for the changes in this patch to take advantage of them in the > > pcie-designware drivers. > > > > Do you plan similar changes to other drivers to take advantage of > > these DWC-generic data and interfaces? If you add generic things to > > the DWC core but only take advantage of them in your driver, I don't > > think they are really usefully generic. > > Could you be more specific what generic things you are referring to? I > am asking because the only part of the changes which is used in my > low-level driver only is introduced in another patch of this series. I asked because three of your patches mention "generic" things, but I didn't see any changes to drivers except pcie-designware: PCI: dwc: Introduce generic platform clocks and reset PCI: dwc: Introduce generic resources getter PCI: dwc: Introduce generic controller capabilities interface I hoped that we would be able to use these to remove some code from existing drivers, but if they only improve maintainability of future drivers, that's useful, too. Bjorn
