On Wed, Nov 23 2022 at 12:38, Thomas Gleixner wrote: > On Wed, Nov 23 2022 at 08:02, Kevin Tian wrote: >>> + bundle->info.hwsize = hwsize ? hwsize : MSI_MAX_INDEX; >> >> patch04 marks that hwsize being 0 means unknown or unlimited in the >> header file. >> >> but here info.hwsize always gets a value i.e. the meaning of 0 only exists >> in this function. What about removing the trailing words about 0 in >> patch04? >> >> - + * @hwsize: The hardware table size (0 if unknown/unlimited) >> + + * @hwsize: The hardware table size > > Fair enough, though I rather make that: > > * @hwsize: The hardware table size or the software defined > index limit > Actually 0 still needs to be valid to guarantee backward compatibility for all existing msi_domain_info implementations. The above is the per device domain creation function, but yes, I can lift that initialization into the common MSI domain creation code. Let me stare at this some more.
