On 21/11/2022 11:52, Shradha Todi wrote: > This patch adds PHY driver support for PCIe controller > found in Tesla FSD SoC. > > Signed-off-by: Niyas Ahmed S T <niyas.ahmed@xxxxxxxxxxx> > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx> > --- > drivers/phy/samsung/Kconfig | 10 + > drivers/phy/samsung/Makefile | 1 + > drivers/phy/samsung/phy-tesla-pcie.c | 397 +++++++++++++++++++++++++++ > 3 files changed, 408 insertions(+) > create mode 100644 drivers/phy/samsung/phy-tesla-pcie.c > Same comment as for PCI. It's the third driver for Samsung Exynos PCIe PHY and every time you will say "but it is different". No, work on unified approach not 3 different drivers. Best regards, Krzysztof