On Thu, Nov 17 2022 at 16:58, Thomas Gleixner wrote: > On Wed, Nov 16 2022 at 14:57, Jason Gunthorpe wrote: > >> And perhaps it would be a bit clearer to put the parent_domain inside >> the msi_domain_info, which is basically acting as an argument bundle >> for a future allocation call? > > Maybe. Let me try. No. That's redundant storage because the domain creation stores the parent domain in irqdomain::parent which is what the hierarchy code uses. That code does not know about msi_domain_info. Thanks, tglx