Re: [PATCH 21/21] PCI: only enable pci realloc when SRIOV bar is not assigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 21 Jan 2012 02:08:37 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> If bios does not assign those BAR or wrong address, then kernel will
> try to do pci realloc.
> 
> in that case, user still can use pci=realloc=off to override it.
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> ---
>  drivers/pci/setup-bus.c |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
> 

I worry about this one; distros may enable IOV to keep a unified kernel
binary and end up messing up all sorts of systems that happen to have
IOV devices that the user doesn't actually care about.

I'd prefer to leave it disabled by default, and let drivers spew a
message about IOV resources being unavailable and mentioning the
realloc= param...

-- 
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux