Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

> > +	if (vmd->irq_domain)
> > +		vmd_set_msi_remapping(vmd, true);
> > +	else
> > +		vmd_set_msi_remapping(vmd, false);
> 
> Why not go one step further:
> 
> 	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.

	Krzysztof



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux