> -----Original Message----- > From: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx> > Sent: Friday, November 11, 2022 4:56 AM > To: Frank Li <frank.li@xxxxxxx> > Cc: mani@xxxxxxxxxx; allenbh@xxxxxxxxx; bhelgaas@xxxxxxxxxx; > dave.jiang@xxxxxxxxx; helgaas@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; > jdmason@xxxxxxxx; kw@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; ntb@xxxxxxxxxxxxxxx > Subject: Re: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > unused field epf_db_phy > > Caution: EXT Email > > On Fri, Nov 11, 2022 at 02:39:12AM +0000, Frank Li wrote: > > > -----Original Message----- > > > From: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx> > > > Sent: Thursday, November 10, 2022 9:29 AM > > > To: Frank Li <frank.li@xxxxxxx> > > > Cc: mani@xxxxxxxxxx; allenbh@xxxxxxxxx; bhelgaas@xxxxxxxxxx; > > > dave.jiang@xxxxxxxxx; helgaas@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; > > > jdmason@xxxxxxxx; kw@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > > > pci@xxxxxxxxxxxxxxx; ntb@xxxxxxxxxxxxxxx > > > Subject: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > > > unused field epf_db_phy > > > > > > Caution: EXT Email > > > > > > On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > > > > From: Frank Li <frank.li@xxxxxxx> > > > > > > > > epf_db_phy is not used, so remove it > > > > > > Sentences end with a period (.). I can fix these things but > > > we can't spend our lives telling you how to write a commit log, > > > check how they are written in the PCI subsystem and follow the > > > pattern. > > > > [Frank Li] Do you need me send new version to fix "."? Or you will plan > > You don't have to write your name in brackets all the time in replies, > it is clear from the indentation what I am replying to and to whom. > > > queue these patches? > > I will queue them but next time I won't fix the commit log myself. Do you have chance to queue it? I still have one patch (enable MSI) depend on these patch series. > > > My means: > > Mani's below feedback will make both live easy. > > What feedback ? I am sorry I don't understand. > > Thank you, > Lorenzo > > > > > > > None use epf_db_phy and remove it. > > > > "epf_db_phy is not used, so remove it" > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > %2F&data=05%7C01%7Cfrank.li%40nxp.com%7C200a354ecae54e7b1af > 408dac3d34892%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638 > 037609466107831%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a > mp;sdata=3ngvYAIP0oTTF1uwAAHFAFmBVi1FvKtgTTw1u3tDXUg%3D&re > served=0 > > > ernel.org%2Fall%2F20171026223701.GA25649%40bhelgaas- > > > > glaptop.roam.corp.google.com&data=05%7C01%7CFrank.Li%40nxp.co > > > > m%7Ca0924bed538a494cbfd508dac3304e8e%7C686ea1d3bc2b4c6fa92cd99c > > > > 5c301635%7C0%7C0%7C638036909484154968%7CUnknown%7CTWFpbGZsb > > > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > > %3D%7C3000%7C%7C%7C&sdata=B3G7sfaSVdLDC8BG95WzpBPFO5l > PJ > > > QpThKDcEexOHfU%3D&reserved=0 > > > > [Frank Li] Thank you for your documents. > > > > > > > > > > > > > Signed-off-by: Frank Li <frank.li@xxxxxxx> > > > > Acked-by: Manivannan Sadhasivam <mani@xxxxxxxxxx> > > > > --- > > > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > index 191924a83454..ee66101cb5c4 100644 > > > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > @@ -136,7 +136,6 @@ struct epf_ntb { > > > > > > > > struct epf_ntb_ctrl *reg; > > > > > > > > - phys_addr_t epf_db_phy; > > > > void __iomem *epf_db; > > > > > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > > > -- > > > > 2.34.1 > > > >
