Hi John, On Mon, Nov 14, 2022 at 2:20 AM John Thomson <git@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > With mt7621 soc_dev_attr fixed to register the soc as a device, > kernel will experience an oops in soc_device_match_attr > > This quirk test was introduced in the staging driver in > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'"), and the staging driver was moved in > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host > controller driver") for the 5.16 kernel > > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@xxxxxxxxxxxxxxxx > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'") > Signed-off-by: John Thomson <git@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > v1 Link: https://lore.kernel.org/lkml/20221104205242.3440388-3-git@xxxxxxxxxxxxxxxxxxxxxxxxxxx/#t > v2: no newline in middle of Fixes tag > --- > drivers/pci/controller/pcie-mt7621.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I am pretty sure I already gave my Acked-by in the previous version of this patch. You should add tags when you submit new versiones. Anyway: Acked-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> Thanks, Sergio Paracuellos