On Thu, Nov 10, 2022 at 12:51:02AM +0000, Verma, Vishal L wrote: > On Wed, 2022-11-09 at 17:35 -0600, Bjorn Helgaas wrote: > > I don't know the history, but OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT and > > OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT seem like sort of weird names > > since they don't match the spec at all ("RCD and RCH Port Register > > Access Supported" and "CXL VH Register Access Supported"). > > Ah the RCH/RCD and VH terminology was only introduced in the CXL-3.0 > spec. When the above defines were added, the spec was at 2.0, and it > used the descriptions: "CXL 1.1 Port Register Access supported", and > "CXL 2.0 Port/Device Register Access supported" (Table 217 in 2.0). Haha, that's annoying :) I didn't dig back through the old versions. I guess CXL folks can decide whether to keep the old names or update.