On Tue, Nov 08, 2022 at 06:06:19PM +0100, Pali Rohár wrote: > On Tuesday 08 November 2022 07:08:16 Bjorn Helgaas wrote: > > Why did the bot tell me the build was *SUCCESSFUL* even though this is > > clearly a problem? Here's the "success" message: > > > > https://lore.kernel.org/all/636a47ad.UocsB2qjv%2FcFWvK2%25lkp@xxxxxxxxx/ > > > > On Tue, Nov 08, 2022 at 03:21:20PM +0800, kernel test robot wrote: > > > > > >> drivers/pci/probe.c:909:6: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > > > if (bus->domain_nr < 0) > > > ^~~~~~~~~~~~~~~~~~ > > > > I set "err = -EINVAL" here; let me know if you prefer something > > different. > > Hello! I agree that there is missing err= assignment. > > Instead of -EINVAL you can use also bus->domain_nr as it is negative and > would contained error code (from ida_alloc() call). Good idea, I adopted that :)
