Re: [PATCH] PCI/ACPI: use ACPI Method Name macro directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2022/11/8 5:24, Bjorn Helgaas 写道:
On Fri, Nov 04, 2022 at 11:24:30AM +0800, Yipeng Zou wrote:
It's convenience to find all at once, use METHOD_NAME__UID as path string.

Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform")
Signed-off-by: Yipeng Zou <zouyipeng@xxxxxxxxxx>
Applied to pci/misc for v6.2, thanks!

I dropped the "Fixes:" tag because there's no reason to backport this
to any older kernels.

I assume you're doing the same for other instances?

   drivers/acpi/acpi_processor.c:          status = acpi_evaluate_integer(handle, "_UID", NULL, &uid);
   drivers/acpi/dock.c:                                    "_UID", NULL, &lbuf);
   drivers/acpi/processor_pdc.c:           status = acpi_evaluate_integer(handle, "_UID", NULL, &tmp);
   drivers/perf/hisilicon/hisi_uncore_hha_pmu.c:                                          "_UID", NULL, &id);
   drivers/xen/xen-acpi-processor.c:               status = acpi_evaluate_integer(handle, "_UID", NULL, &tmp);
yes, there are some other instances, will replace them together.
---
  drivers/pci/pci-acpi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index a46fec776ad7..068d6745bf98 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -67,7 +67,7 @@ static acpi_status acpi_match_rc(acpi_handle handle, u32 lvl, void *context,
  	unsigned long long uid;
  	acpi_status status;
- status = acpi_evaluate_integer(handle, "_UID", NULL, &uid);
+	status = acpi_evaluate_integer(handle, METHOD_NAME__UID, NULL, &uid);
  	if (ACPI_FAILURE(status) || uid != *segment)
  		return AE_CTRL_DEPTH;
--
2.17.1

--
Regards,
Yipeng Zou




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux