On Mon, Oct 31, 2022 at 05:08:18PM +0800, Slark Xiao wrote:
> At 2022-10-29 00:06:21, "Bjorn Helgaas" <helgaas@xxxxxxxxxx> wrote:
> >I think the best thing here would be two patches. One patch would add
> >PCI_VENDOR_ID_THALES to pci_ids.h and also add a use of it in the MHI
> >driver. The second patch would do the same for PCI_VENDOR_ID_QUECTEL.
> >
> >Then each one is logically self-contained.
>
> I must make sure these ids are applied, then I could commit the
> changes in MHI driver side. Otherwise it will cause build error.
>
> So I combine QUECTEL with THALES as a single patch. Shall I separate
> it from each other? 1 for PCI IDs, and another for MHI change. It
> would be better, I think.
Make two patches:
- A single patch that adds PCI_VENDOR_ID_THALES to pci_ids.h and
also adds a use of it in the MHI driver.
- A single patch that adds PCI_VENDOR_ID_QUECTEL to pci_ids.h and
also adds a use of it in the MHI driver.
That way there's no possibility of build error and no need to
coordinate patches.
Similar previous work:
https://git.kernel.org/linus/fae74feacd2d ("hisi_acc_qm: Move VF PCI device IDs to common header")
https://git.kernel.org/linus/d3826a95222c ("nfp: add support for NFP3800/NFP3803 PCIe devices")
https://git.kernel.org/linus/4fb0abfee424 ("x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and (A0h-AFh) PCI IDs")
