At 2022-10-28 11:51:23, "Bagas Sanjaya" <bagasdotme@xxxxxxxxx> wrote: >On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: >> In MHI driver, there are some companies product still do not have their >> own PCI vendor macro. So we add it here to make the code neat. Ref ID >> could be found in link https://pcisig.com/membership/member-companies >> and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as >> their IOT modem card's trademark. So you will find 0x1269 belongs to >> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to >> Thales. >> > >The patch description is confusing me. > >What about below instead? > >``` >Add missing vendor ID for Cinterion (which is 0x1269). >``` > As you said 0x1269 belongs to Thales (not Cinterion), So I write it about the details. >> Signed-off-by: Slark Xiao <slark_xiao@xxxxxxx> >> --- >> include/linux/pci_ids.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index b362d90eb9b0..9e2b6286f53f 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -1765,6 +1765,8 @@ >> #define PCI_VENDOR_ID_SATSAGEM 0x1267 >> #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 >> >> +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ >> + >> #define PCI_VENDOR_ID_ENSONIQ 0x1274 >> #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 >> #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 >> @@ -2585,6 +2587,8 @@ >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >> >> +#define PCI_VENDOR_ID_QUECTEL 0x1eac >> + > >Why pourring in Quectel ID while this patch is about Cinterion? > >Thanks. > Patch title is for 2 vendors, Quectel and Cinterion. May I add 2 different VID at the same time? >-- >An old man doll... just what I always wanted! - Clara
