At 2022-10-27 22:27:42, "Bjorn Helgaas" <helgaas@xxxxxxxxxx> wrote: >On Thu, Oct 27, 2022 at 07:51:23PM +0800, Slark Xiao wrote: >> In MHI driver, there are some companies product still >> do not have their own PCI vendor macro. So we add it >> here to make the code neat. Ref ID could be found in >> link https://pcisig.com/membership/member-companies. > >Rewrap to fill 75 columns. > >Post along with the patch that uses the definitions. > >> Signed-off-by: Slark Xiao <slark_xiao@xxxxxxx> >> --- >> include/linux/pci_ids.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index b362d90eb9b0..e3bfea06b90e 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -172,6 +172,10 @@ >> #define PCI_DEVICE_ID_BERKOM_A4T 0xffa4 >> #define PCI_DEVICE_ID_BERKOM_SCITEL_QUADRO 0xffa8 >> >> +#define PCI_VENDOR_ID_CINTERION 0x1269 > >The URL above says 0x1269 belongs to Thales. Maybe add a comment to >that effect, similar to the one for PCI_VENDOR_ID_CB. > >> +#define PCI_VENDOR_ID_QUECTEL 0x1eac > >Both new definitions look like they're dropped in a random location. >Please move them so the vendor IDs in the file remain sorted by >numeric value. > Hi Bjorn, V2 version is sent. I add explanation about the relationship between Thales and CInterion. And I just find these VIDs are sorted by numeric, so I fix it in v2. Thanks. >> #define PCI_VENDOR_ID_COMPAQ 0x0e11 >> #define PCI_DEVICE_ID_COMPAQ_TOKENRING 0x0508 >> #define PCI_DEVICE_ID_COMPAQ_TACHYON 0xa0fc >> -- >> 2.34.1 >>
