On Wed, Oct 19, 2022 at 06:29:11PM -0700, Matt Ranostay wrote: > Added dev_warn messages to alert of devicetree misconfigurations > for incorrect num-lanes setting, or the lack of one being defined. s/Added/Add/ if you repost for anything else: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.16#n95 > + dev_warn(dev, "defined num-lanes %u is greater than the " > + "allowed maximum of %u, defaulting to 1\n", > + num_lanes, data->max_lanes); Don't repost just for this, but I generally prefer to keep printf strings intact even if they exceed 80 columns, because it makes it easier for someone to grep for something like "greater than the allowed". > + num_lanes = 1; > + } > pcie->num_lanes = num_lanes; > > if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48))) > -- > 2.38.GIT >