Re: [PATCH 3/4] PCI: restrict subordinate buses to those reachable via host bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 18, 2012 at 8:52 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> If we make a quirk for this machine, we still have the question of
> what to do with my patches.  I assert that if Linux ever reconfigures
> any bus numbers or does any configuration of hot-added P2P bridges, it
> must pay attention to the host bridge bus number window.  Therefore, I
> think we need something like this series even if we make a quirk.

We may need more smart way to find unused bus range instead of just
just max+1 and ++max.

For example:  one bridge (A) have two child bridges (B and C),
A: bus range: 10-2f
B: bus range: 11-1f
C: bus range: 20-2f

when some broken case happen, B bus BIOS assigned bus range will be
all cleared in first pass.
but C bus is ok.  but in second bus, bus will be assigned to 30- .
that is totally wrong, We should still
try to use bus 11-1f at first for bus B.

your patches should be ok, only exception should be considered: some
default link root bus could access
out of bus range state with _CRS stating.  some kind of transparent
bridge concept.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux