Hi Bjorn > > On Mon, Oct 17, 2022 at 04:23:37PM +0200, Christian Gmeiner wrote: > > From: Christian GMEINER <Christian.GMEINER@xxxxxxxxxxxxx> > > > > Signed-off-by: Christian GMEINER <Christian.GMEINER@xxxxxxxxxxxxx> > > I tweaked it to shorten the name in the style of other entries and > sort it by numeric ID. > I am fine with that .. was not sure if there needs to be a match of the used define and the official "Member company" name: https://pcisig.com/membership/member-companies?combine=%22Bachmann+electronic%22 > I assume there's a driver that will use this definition. If so, you > might want to post this patch (including my ack) along with the driver > so they get merged together. But let me know if you need me to take > it directly. > I hope that one driver will see the public light sooner than later but I have no official time frame. > > Also it will be helpful if you can add the item to the PCI ID database > here: https://pci-ids.ucw.cz/read/PC?restrict=0, which will let lspci > identify devices with this Vendor ID. > Done - thanks. > Bjorn > > > commit 2fa819fdbb2b ("PCI: Add Bachmann electronic GmbH vendor ID") > Author: Christian GMEINER <Christian.GMEINER@xxxxxxxxxxxxx> > Date: Mon Oct 17 16:23:37 2022 +0200 > > PCI: Add Bachmann electronic GmbH vendor ID > > Link: https://lore.kernel.org/r/20221017142338.1445199-1-christian.gmeiner@xxxxxxxxx > Signed-off-by: Christian GMEINER <Christian.GMEINER@xxxxxxxxxxxxx> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index b362d90eb9b0..4cc0e9ecd398 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2,7 +2,7 @@ > /* > * PCI Class, Vendor and Device IDs > * > - * Please keep sorted. > + * Please keep sorted by numeric ID. > * > * Do not add new entries to this file unless the definitions > * are shared between multiple drivers. > @@ -153,7 +153,7 @@ > > #define PCI_CLASS_OTHERS 0xff > > -/* Vendors and devices. Sort key: vendor first, device next. */ > +/* Vendors and devices. Numeric sort key: vendor first, device next. */ > #define PCI_VENDOR_ID_PCI_SIG 0x0001 > > #define PCI_VENDOR_ID_LOONGSON 0x0014 > @@ -172,6 +172,8 @@ > #define PCI_DEVICE_ID_BERKOM_A4T 0xffa4 > #define PCI_DEVICE_ID_BERKOM_SCITEL_QUADRO 0xffa8 > > +#define PCI_VENDOR_ID_BACHMANN 0x0bae > + > #define PCI_VENDOR_ID_COMPAQ 0x0e11 > #define PCI_DEVICE_ID_COMPAQ_TOKENRING 0x0508 > #define PCI_DEVICE_ID_COMPAQ_TACHYON 0xa0fc > > > --- > > include/linux/pci_ids.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index b362d90eb9b0..b93a52977d85 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -166,6 +166,8 @@ > > > > #define PCI_VENDOR_ID_UBIQUITI 0x0777 > > > > +#define PCI_VENDOR_ID_BACHMANN_ELECTRONIC 0x0bae > > + > > #define PCI_VENDOR_ID_BERKOM 0x0871 > > #define PCI_DEVICE_ID_BERKOM_A1T 0xffa1 > > #define PCI_DEVICE_ID_BERKOM_T_CONCEPT 0xffa2 > > -- > > 2.37.3 > > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy
