Re: [PATCH v2 1/4] sched/isolation: Fix style issues reported by checkpatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/4] sched/isolation: Fix style issues reported by checkpatch
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Fri, 14 Oct 2022 10:28:46 +0200
Cc: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Ben Segall <bsegall@xxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>, Valentin Schneider <vschneid@xxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Lai Jiangshan <jiangshanlai@xxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Frederic Weisbecker <frederic@xxxxxxxxxx>, Phil Auld <pauld@xxxxxxxxxx>, Antoine Tenart <atenart@xxxxxxxxxx>, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, Wang Yufen <wangyufen@xxxxxxxxxx>, mtosatti@xxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <20221013184028.129486-2-leobras@redhat.com>
References: <20221013184028.129486-1-leobras@redhat.com> <20221013184028.129486-2-leobras@redhat.com>

On Thu, Oct 13, 2022 at 03:40:26PM -0300, Leonardo Bras wrote:
> scripts/checkpatch.pl warns about:
> - extern prototypes should be avoided in .h files

Checkpatch is wrong... :-)

(and yeah, I know the opinions on extern are divided, but I like it)

References:
- [PATCH v2 0/4] CPU isolation improvements
  - From: Leonardo Bras
- [PATCH v2 1/4] sched/isolation: Fix style issues reported by checkpatch
  - From: Leonardo Bras

Prev by Date: Re: [PATCH V5 0/3] PCI: designware-ep: Fix DBI access before core init
Next by Date: Re: [PATCH v2 2/4] sched/isolation: Improve documentation
Previous by thread: [PATCH v2 1/4] sched/isolation: Fix style issues reported by checkpatch
Next by thread: [PATCH v2 2/4] sched/isolation: Improve documentation
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]