On Wed, Sep 28, 2022 at 04:35:10PM +0200, Thierry Reding wrote: > On Wed, Sep 28, 2022 at 02:19:11PM +0200, Pali Rohár wrote: > > Simplify pci-tegra.c driver code and use new PCI_CONF1_EXT_ADDRESS() macro > > for accessing PCI config space. > > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > --- > > Please look also at this related patch: > > https://patchwork.kernel.org/project/linux-pci/patch/20220911113216.14892-1-pali@xxxxxxxxxx/ > > --- > > drivers/pci/controller/pci-tegra.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > I had to go chase down the patch that introduces PCI_CONF1_EXT_ADDRESS. > It would've been easier if this had been part of the series that > introduced that, or if you had provided a link to that patch here. > > Anyway, looks like this is equivalent to the existing inline function, > so: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> After looking at the linked patch, perhaps revise this one more time and remove the comment above the removed helper since it's now just a duplication of what the PCI_CONF1_EXT_ADDRESS comments say. Thierry
Attachment:
signature.asc
Description: PGP signature
