Hi, > -----Original Message----- > From: kernel test robot <lkp@xxxxxxxxx> > Sent: Friday, September 23, 2022 11:21 PM > To: Xiaochun Lee <lixiaochun.2888@xxxxxxx>; > nirmal.patel@xxxxxxxxxxxxxxx; jonathan.derrick@xxxxxxxxx > Cc: kbuild-all@xxxxxxxxxxxx; lpieralisi@xxxxxxxxxx; robh@xxxxxxxxxx; > kw@xxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Xiaochun XC17 Li <lixc17@xxxxxxxxxx> > Subject: [External] Re: [PATCH v1] PCI: Set no io resource for bridges that > behind VMD controller > > Hi Xiaochun, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] [also build test ERROR on > linus/master v6.0-rc6 next-20220923] [If your patch is applied to the wrong > git tree, kindly drop us a note. Hi, thanks for your reply, this patch is only expected to be applied on x86 or x64, actually function "is_vmd()" is just defined in arch/x86/include/asm/pci.h, do we need to support it on arch um? > And when submitting patch, we suggest to use '--base' as documented in > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit- > scm.com%2Fdocs%2Fgit-format- > patch%23_base_tree_information&data=05%7C01%7Clixc17%40lenov > o.com%7C63bd7990b33f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa9 > 34df372b16203%7C0%7C0%7C637995433448231363%7CUnknown%7CTWF > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TGZ2LnHsHCrJLW7WBBMZ > lFxv8SIaQNmCGC1bEv2BEDE%3D&reserved=0] > > url: > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > b.com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FXiaochun-Lee%2FPCI-Set- > no-io-resource-for-bridges-that-behind-VMD-controller%2F20220913- > 213745&data=05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4d > d9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0 > %7C637995433448231363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C&sdata=3NULvkgYg0fWTopgYY5EYHsLIBPdTEcMxbz5Tj12D0E% > 3D&reserved=0 > base: > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.k > ernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fhelgaas%2Fpci.git&a > mp;data=05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4dd9b4bc08 > da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0%7C63799 > 5433448231363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL > CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a > mp;sdata=ZTZ7kKlwOk7IB3MN0rRwqHaNGGl4OiwrR7AjImBbTqc%3D& > reserved=0 next > config: um-allmodconfig > (https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow > nload.01.org%2F0day- > ci%2Farchive%2F20220924%2F202209240714.ronvmf1X- > lkp%40intel.com%2Fconfig&data=05%7C01%7Clixc17%40lenovo.com% > 7C63bd7990b33f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372 > b16203%7C0%7C0%7C637995433448231363%7CUnknown%7CTWFpbGZsb3 > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000%7C%7C%7C&sdata=6xMM7Fh9bKGnzBlmeu8kki3yvGGQ > 2k%2FKCp%2BqvoLt4zU%3D&reserved=0) > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): > # > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > b.com%2Fintel-lab- > lkp%2Flinux%2Fcommit%2Ff97a8ba561d7cf5a755c8f42421138e8b1073cf9& > amp;data=05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4dd9b4bc0 > 8da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0%7C6379 > 95433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > amp;sdata=4mjCA86AEbwN9eIiw1%2BLUPlf0%2BV2juqoDo7ojKSMweY%3D > &reserved=0 > git remote add linux-review > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > b.com%2Fintel-lab- > lkp%2Flinux&data=05%7C01%7Clixc17%40lenovo.com%7C63bd7990b3 > 3f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0% > 7C0%7C637995433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000 > %7C%7C%7C&sdata=YusFni1tvPN89d2e%2B8yADL3jbwjuydLs0RD3NSjj > 2MA%3D&reserved=0 > git fetch --no-tags linux-review Xiaochun-Lee/PCI-Set-no-io-resource- > for-bridges-that-behind-VMD-controller/20220913-213745 > git checkout f97a8ba561d7cf5a755c8f42421138e8b1073cf9 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=um SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/pci/quirks.c: In function 'quirk_vmd_no_iosize': > >> drivers/pci/quirks.c:5985:13: error: implicit declaration of function > >> 'is_vmd' [-Werror=implicit-function-declaration] > 5985 | if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) { > | ^~~~~~ > cc1: some warnings being treated as errors > > > vim +/is_vmd +5985 drivers/pci/quirks.c > > 5959 > 5960 #if defined(CONFIG_X86_64) || defined(CONFIG_X86) > 5961 /* > 5962 * VMD-enabled root ports use Enhanced Configuration Access > Mechanism (ECAM) > 5963 * access PCI Express configuration space, and offer VMD_CFGBAR > as > 5964 * base of PCI Express configuration space for the bridges behind it. > 5965 * The configuration space includes IO resources, but these IO > 5966 * resources are not actually used on X86, especially the NVMes as > 5967 * device connnected on this hot plug bridges, and it can result > 5968 * in BAR#13 assign IO resource failed. So we clear IO resources > 5969 * by setting an IO base value greater than limit to these bridges. > 5970 * Hence, append kernel parameter "pci=hpiosize=0KB" can avoid > 5971 * this BAR#13 failed messages show out. > 5972 */ > 5973 static void quirk_vmd_no_iosize(struct pci_dev *bridge) > 5974 { > 5975 u8 io_base_lo, io_limit_lo; > 5976 u16 io_low; > 5977 u32 io_upper16; > 5978 unsigned long io_mask, base, limit; > 5979 > 5980 io_mask = PCI_IO_RANGE_MASK; > 5981 if (bridge->io_window_1k) > 5982 io_mask = PCI_IO_1K_RANGE_MASK; > 5983 > 5984 /* VMD Domain */ > > 5985 if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) { > > -- > 0-DAY CI Kernel Test Service > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2F01.or > g%2Flkp&data=05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4 > dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0 > %7C637995433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C&sdata=4qYtyE86mw9VyFbB3QKJqtldq6relV2Cunv9STAmmqA > %3D&reserved=0
