On Fri, Sep 23, 2022 at 04:14:39PM -0500, Bjorn Helgaas wrote: > On Wed, Sep 07, 2022 at 01:40:20PM +0800, Icenowy Zheng wrote: > > The DT binding of FU740 PCIe does not enforce a clock-names property, > > and there exist some device tree that has a clock name that does not > > stick to the one used by Linux DT (e.g. the one shipped with current > > U-Boot mainline). > > > > Drop the name in the clock request, instead just pass NULL (because > > this device should have only a single clock). > > If you rework this for any reason, please capitalize the subject line > to match the convention: It prob needs a v2 because the first sentence of the commit message is wrong, I recently added the binding enforcement. Thanks, Conor. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/pci/controller/dwc/pcie-fu740.c > > > Signed-off-by: Icenowy Zheng <uwu@xxxxxxxxxx> > > --- > > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c > > index 0c90583c078b..edb218a37a4f 100644 > > --- a/drivers/pci/controller/dwc/pcie-fu740.c > > +++ b/drivers/pci/controller/dwc/pcie-fu740.c > > @@ -315,7 +315,7 @@ static int fu740_pcie_probe(struct platform_device *pdev) > > return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n"); > > > > /* Fetch clocks */ > > - afp->pcie_aux = devm_clk_get(dev, "pcie_aux"); > > + afp->pcie_aux = devm_clk_get(dev, NULL); > > if (IS_ERR(afp->pcie_aux)) > > return dev_err_probe(dev, PTR_ERR(afp->pcie_aux), > > "pcie_aux clock source missing or invalid\n"); > > -- > > 2.37.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > _______________________________________________ > linux-riscv mailing list > linux-riscv@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-riscv
