On Fri, 16 Dec 2011 16:52:45 -0800 Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > During reviewing > | PCI: pciehp: wait 1000 ms before Link Training check > Linus said: > >... > > That's a *long* time, and it's irritating to the user. It makes the > > user think "the machine is slow". > >... > > And quite frankly, an unconditional one-second delay here seems bad. > >Two seconds was unacceptable, one second is just bad. > > Try to access the pci conf of pci device that is supposed to show up in 1s, > if could read back valid vender/device id, could bail out early. > > Related discussion could be found: > https://lkml.org/lkml/2011/12/6/339 > > -v2: seperate code to pci_bus_read_dev_vendor_id() from pci_scan_device() > and reuse it from pciehp code. Suggested by Matthew Wilcox. Kenji-san, you ok with this one? Any chance you could test? Thanks, -- Jesse Barnes, Intel Open Source Technology Center
Attachment:
signature.asc
Description: PGP signature
