On Mon, Sep 12, 2022 at 03:02:11AM +0300, Serge Semin wrote:
[...]
> I prefer splitting the probe method up into a set of small and
> coherent methods. It IMO improves the code readability for just no
> price since the compiler will embed the single-time used static
> methods anyway.
I will get back to this thread at -rc7 - we will decide a merge
strategy then.
Lorenzo
> -Sergey
>
> >
> > Thanks,
> > Lorenzo
> >
> > > + if (IS_ERR(btpci))
> > > + return PTR_ERR(btpci);
> > > +
> > > + return bt1_pcie_add_port(btpci);
> > > +}
> > > +
> > > +static int bt1_pcie_remove(struct platform_device *pdev)
> > > +{
> > > + struct bt1_pcie *btpci = platform_get_drvdata(pdev);
> > > +
> > > + bt1_pcie_del_port(btpci);
> > > +
> > > + return 0;
> > > +}
> > > +
> > > +static const struct of_device_id bt1_pcie_of_match[] = {
> > > + { .compatible = "baikal,bt1-pcie" },
> > > + {},
> > > +};
> > > +MODULE_DEVICE_TABLE(of, bt1_pcie_of_match);
> > > +
> > > +static struct platform_driver bt1_pcie_driver = {
> > > + .probe = bt1_pcie_probe,
> > > + .remove = bt1_pcie_remove,
> > > + .driver = {
> > > + .name = "bt1-pcie",
> > > + .of_match_table = bt1_pcie_of_match,
> > > + },
> > > +};
> > > +module_platform_driver(bt1_pcie_driver);
> > > +
> > > +MODULE_AUTHOR("Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>");
> > > +MODULE_DESCRIPTION("Baikal-T1 PCIe driver");
> > > +MODULE_LICENSE("GPL");
> > > --
> > > 2.35.1
> > >
