[ Adding author and reviewers of commit 63338a38db95 again ]
On 9/16/22 2:00 AM, Liang He wrote:
> In jailhouse_paravirt(), we should hold the reference returned from
> of_find_compatible_node() which has increased the refcount and then
> call of_node_put() with it when done.
>
> Fixes: 63338a38db95 ("jailhouse: Provide detection for non-x86 systems")
> Signed-off-by: Liang He <windhl@xxxxxxx>
> Co-developed-by: Kelin Wang <wangkelin2023@xxxxxxx>
> Signed-off-by: Kelin Wang <wangkelin2023@xxxxxxx>
Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@xxxxxxxxxxxxx>
> ---
>
> v2: use proper return type not the 'np' pointer
>
> include/linux/hypervisor.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/hypervisor.h b/include/linux/hypervisor.h
> index 9efbc54e35e5..f11eec57ea63 100644
> --- a/include/linux/hypervisor.h
> +++ b/include/linux/hypervisor.h
> @@ -27,7 +27,11 @@ static inline void hypervisor_pin_vcpu(int cpu)
>
> static inline bool jailhouse_paravirt(void)
> {
> - return of_find_compatible_node(NULL, NULL, "jailhouse,cell");
> + struct device_node *np = of_find_compatible_node(NULL, NULL, "jailhouse,cell");
> +
> + of_node_put(np);
> +
> + return np ? true : false;
> }
>
> #endif /* !CONFIG_X86 */
>
Regards,
Srivatsa
VMware Photon OS
