The first 3 patches fix the actual PCI AER issue by moving the nbio HDP remap callback to the GMC code where it is used. Lijo prefered calling the common hw init early, but that ran into additional problems on vega systems because it depends on doorbell apertures having been set up for IH and SDMA so we run into an ordering problem there. We already call the other NBIO callbacks as well as the HDP callbacks from other IPs when they are needed so it seems logical to me to move the HDP remap into GMC since it's mainly used as part of memory management anyway. The 4th patch just fixes up nbio 7.7 for consistency. The next 2 patches are optional, but make the code more consistent with that we do for other IPs. See those patches for some additional comments about the ordering with respect to the doorbell setup. I didn't notice any problems in my testing and the VCN doorbell setup already breaks that rule, so I'm not sure if it's actually necesary or not. Finally the last patch enabled early common IP init to happen before GMC. It's not strictly necessary with the first 3 patches, but there may be value in it to have the common stuff enabled before GMC. Alex Deucher (7): drm/amdgpu: move nbio remap_hdp_registers() to gmc9 code drm/amdgpu: move nbio remap_hdp_registers() to gmc10 code drm/amdgpu: move nbio remap_hdp_registers() to gmc11 code drm/amdgpu: add HDP remap functionality to nbio 7.7 drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega drm/amdgpu: make sure to init common IP before gmc drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 ++++++++-- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 7 +++++ drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 7 +++++ drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++++ drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 9 ++++++ drivers/gpu/drm/amd/amdgpu/nv.c | 6 ---- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 ++++ drivers/gpu/drm/amd/amdgpu/soc15.c | 32 ---------------------- drivers/gpu/drm/amd/amdgpu/soc21.c | 6 ---- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 4 +++ drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 4 +++ 11 files changed, 54 insertions(+), 47 deletions(-) -- 2.37.2
