Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-09-09 10:16, Lorenzo Pieralisi wrote:
Nit: please capitalize beginning of the sentence in the subject - that's
what we do for PCI controllers commits.

"PCI: apple: Do not leak reset GPIO on unbind/unload/error"

On Mon, Sep 05, 2022 at 07:15:23PM -0700, Dmitry Torokhov wrote:
The driver allocates reset GPIO in apple_pcie_setup_port() but neither
releases the resource, nor uses devm API to have it released
automatically.

Let's fix this by switching to devm API. While at it let's use generic
devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node()
- this will allow us top stop exporting the latter down the road.

Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")

Should I take it via the PCI tree ? Usually we send fixes through -rcX
only if the fix applies to code merged last merge window, which is not
the case here, so I would queue if for v6.1.

I think 6.1 is perfectly fine.

Thanks,

        M.
--
Jazz is not dead. It just smells funny...



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux