On Wed, Jan 4, 2012 at 3:02 PM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 04 Jan 2012 14:56:19 -0500 (EST) > David Miller <davem@xxxxxxxxxxxxx> wrote: > >> From: Neil Horman <nhorman@xxxxxxxxxxxxx> >> Date: Wed, 4 Jan 2012 14:51:34 -0500 >> >> > On Wed, Jan 04, 2012 at 09:19:52AM -0800, Jesse Barnes wrote: >> >> On Tue, 3 Jan 2012 13:53:05 -0500 >> >> Neil Horman <nhorman@xxxxxxxxxxxxx> wrote: >> >> >> >> > On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote: >> >> > > From: Neil Horman <nhorman@xxxxxxxxxxxxx> >> >> > > Date: Tue, 3 Jan 2012 10:29:54 -0500 >> >> > > >> >> > > > This warning was recently reported to me: >> >> > > >> >> > > I've hit this too, see: >> >> > > >> >> > > http://marc.info/?l=linux-kernel&m=132458146927890&w=2 >> >> > > >> >> > > and my analysis at: >> >> > > >> >> > > http://marc.info/?l=linux-arch&m=132458391128660&w=2 >> >> > > >> >> > Yup, your analysis is correct. Regardless of the why behind msi enablement >> >> > failing, we need to gate the kobject_del/put in free_msi_irqs on successful >> >> > completion of kobject_init_and_add in populate_msi_sysfs. This patch does that, >> >> > using the parent pointer as a flag. >> >> >> >> I applied this to my -next branch; doesn't seem critical to land >> >> immediately. If you disagree let me know and I'll pull it over to my >> >> for-linus branch instead. >> >> >> >> Thanks, >> > I'm ok with it waiting, but I'll defer to Dave and others who have seen it >> > occur. It sounds like its alot of log noise. >> >> The bug only exists in the PCI -next code I thought. > > Oh yeah, looks like it. Lost track of my -next vs master branches > there... Er... Neil's commit log in the patch itself has an oops from 3.1.6 in it. If the bug the patch fixes is only present in -next PCI code, how did it get hit on that release? Did we switch to talking about some other patch here and I'm just confused? josh -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
