On Tue, Sep 06, 2022 at 05:23:46PM -0500, Bjorn Helgaas wrote: > @@ -42,6 +42,13 @@ void pci_disable_ptm(struct pci_dev *dev) > pci_write_config_word(dev, ptm + PCI_PTM_CTRL, ctrl); > } Since you export these, I suggest adding kernel-doc to explain how these are supposed to be used in drivers (pre-conditions etc.). > +void pci_disable_ptm(struct pci_dev *dev) > +{ > + __pci_disable_ptm(dev); > + dev->ptm_enabled = 0; > +} > +EXPORT_SYMBOL(pci_disable_ptm); EXPORT_SYMBOL_GPL()?