Re: [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 5 Sep 2022 16:36:34 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Don Dutile <ddutile@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Minturn Dave B <dave.b.minturn@xxxxxxxxx>, Jason Ekstrand <jason@xxxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Xiong Jianxin <jianxin.xiong@xxxxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Martin Oliveira <martin.oliveira@xxxxxxxxxxxxx>, Chaitanya Kulkarni <ckulkarnilinux@xxxxxxxxx>, Ralph Campbell <rcampbell@xxxxxxxxxx>, Stephen Bates <sbates@xxxxxxxxxxxx>
In-reply-to: <20220825152425.6296-6-logang@deltatee.com>
References: <20220825152425.6296-1-logang@deltatee.com> <20220825152425.6296-6-logang@deltatee.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Aug 25, 2022 at 09:24:22AM -0600, Logan Gunthorpe wrote:
> +	if (bio->bi_bdev && bio->bi_bdev->bd_disk &&
> +	    blk_queue_pci_p2pdma(bio->bi_bdev->bd_disk->queue))

bdev->bd_disk is never NULL.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v9 0/8] Userspace P2PDMA with O_DIRECT NVMe devices
  - From: Logan Gunthorpe
- [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()
  - From: Logan Gunthorpe

Prev by Date: Re: [PATCH v9 4/8] lib/scatterlist: add check when merging zone device pages
Next by Date: Re: [PATCH v9 6/8] block: set FOLL_PCI_P2PDMA in bio_map_user_iov()
Previous by thread: [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()
Next by thread: Re: [PATCH v9 5/8] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]