+ linux-pci ---- On Mon, 05 Sep 2022 14:32:29 +0200 Li Chen wrote --- > From: Li Chen lchen@xxxxxxxxxxxxx> > > This error message will also be reported by > j721e_pcie_ctrl_init when check j721e_pcie_set_mode > return value, so remove it. > > Signed-off-by: Li Chen lchen@xxxxxxxxxxxxx> > --- > drivers/pci/controller/cadence/pci-j721e.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > index a82f845cc4b5..360a3cc1fae3 100644 > --- a/drivers/pci/controller/cadence/pci-j721e.c > +++ b/drivers/pci/controller/cadence/pci-j721e.c > @@ -169,16 +169,11 @@ static int j721e_pcie_set_mode(struct j721e_pcie *pcie, struct regmap *syscon, > u32 mask = J721E_MODE_RC; > u32 mode = pcie->mode; > u32 val = 0; > - int ret = 0; > > if (mode == PCI_MODE_RC) > val = J721E_MODE_RC; > > - ret = regmap_update_bits(syscon, offset, mask, val); > - if (ret) > - dev_err(dev, "failed to set pcie mode\n"); > - > - return ret; > + return regmap_update_bits(syscon, offset, mask, val); > } > > static int j721e_pcie_set_link_speed(struct j721e_pcie *pcie, > -- > 2.37.2 > > >
