On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> so that gpiolib can be cleaned a bit, so let's switch to the generic
> device property API.
>
> I believe that the only reason the driver, instead of the standard
> devm_gpiod_get(), used devm_gpiod_get_from_of_node() is because it
> wanted to set up a pretty consumer name for the GPIO, and we now have
> a special API for that.
...
> - gpiod = devm_gpiod_get_from_of_node(&pdev->dev, np,
> - "nvidia,phy-reset-gpio",
> - 0, GPIOD_OUT_HIGH,
> - "ulpi_phy_reset_b");
> + gpiod = devm_gpiod_get(&pdev->dev, "nvidia,phy-reset",
> + GPIOD_OUT_HIGH);
> err = PTR_ERR_OR_ZERO(gpiod);
What does _OR_ZERO mean now?
> if (err) {
> dev_err(&pdev->dev,
> "Request failed for reset GPIO: %d\n", err);
> return err;
> }
--
With Best Regards,
Andy Shevchenko
