Re: [PATCH] fix for a bash issue [...]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

> diff --git a/update-pciids.sh b/update-pciids.sh
> index 5e77109..708e3b3 100755
> --- a/update-pciids.sh
> +++ b/update-pciids.sh
> @@ -5,7 +5,7 @@
>  set -e
>  SRC="http://pciids.sourceforge.net/v2.2/pci.ids";
>  DEST=pci.ids
> -PCI_COMPRESSED_IDS=
> +PCI_COMPRESSED_IDS=0

It is quite improbable that this patch changes anything -- when sed'ing
update-pciids.sh to get the update-pciids which is really installed,
the right-hand side of this assignment is replaced.

Better change the condition, so that it can cope with an empty variable
(e.g., use "==" instead of "-eq").

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@xxxxxx>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"The road to hell is paved with melting snowballs." -- Larry Wall
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux