Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on linus/master v6.0-rc3 next-20220901] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-PM-Always-disable-PTM-for-all-devices-during-suspend/20220903-073808 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220903/202209031256.McjuB8mz-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/809e1c954b459ee37193c4ab9fa843243fbd7fa9 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bjorn-Helgaas/PCI-PM-Always-disable-PTM-for-all-devices-during-suspend/20220903-073808 git checkout 809e1c954b459ee37193c4ab9fa843243fbd7fa9 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/pci/pci-driver.c: In function 'pci_pm_runtime_resume': >> drivers/pci/pci-driver.c:1350:22: error: 'struct pci_dev' has no member named 'ptm_enabled'; did you mean 'ats_enabled'? 1350 | if (pci_dev->ptm_enabled) | ^~~~~~~~~~~ | ats_enabled vim +1350 drivers/pci/pci-driver.c 1335 1336 static int pci_pm_runtime_resume(struct device *dev) 1337 { 1338 struct pci_dev *pci_dev = to_pci_dev(dev); 1339 const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; 1340 pci_power_t prev_state = pci_dev->current_state; 1341 int error = 0; 1342 1343 /* 1344 * Restoring config space is necessary even if the device is not bound 1345 * to a driver because although we left it in D0, it may have gone to 1346 * D3cold when the bridge above it runtime suspended. 1347 */ 1348 pci_pm_default_resume_early(pci_dev); 1349 > 1350 if (pci_dev->ptm_enabled) 1351 pci_enable_ptm(pci_dev, NULL); 1352 1353 if (!pci_dev->driver) 1354 return 0; 1355 1356 pci_fixup_device(pci_fixup_resume_early, pci_dev); 1357 pci_pm_default_resume(pci_dev); 1358 1359 if (prev_state == PCI_D3cold) 1360 pci_pm_bridge_power_up_actions(pci_dev); 1361 1362 if (pm && pm->runtime_resume) 1363 error = pm->runtime_resume(dev); 1364 1365 return error; 1366 } 1367 -- 0-DAY CI Kernel Test Service https://01.org/lkp
