On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: > There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT > and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these > from core Vmbus code. Move the defines where they belong. It's a minor annoyance that the above is 81 characters long when "git log" adds its 4-character indent, so it wraps in a default terminal. It'd be nice if we could settle on a conventional spelling of "Vmbus", too. "Vmbus" looks to be in the minority: $ git grep Vmbus | wc -l; git grep VMbus | wc -l; git grep VMBus | wc -l 4 82 62 FWIW, one published microsoft.com doc uses "VMBus": https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/hyper-v-architecture