On Wed, Aug 24, 2022 at 08:27:58PM +0530, Manivannan Sadhasivam wrote: > On Tue, Jul 26, 2022 at 11:34:00PM +0300, Dmitry Baryshkov wrote: > > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > > used in the RC mode. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > Thanks, > Mani > > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 93d75cda4b04..f85f2579c087 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > > if (ret) > > return ret; > > > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); > > + if (ret) > > + return err_deinit; Oops... Missed this one. Should be goto err_deinit; Thanks, Mani > > + > > ret = phy_power_on(pcie->phy); > > if (ret) > > goto err_deinit; > > -- > > 2.35.1 > > > > -- > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம்