On Sun, Dec 11, 2011 at 10:35:07PM +0100, Helge Deller wrote: > In my machine I'm running two dual-DVI PCI video cards (NVidia GeForce 7300 LE PCI, ATI FireMV 2200 PCI). > Both are PCI and not PCI-Express cards. > > Somewhere after kernel 2.6.34 the nouveau and the radeon DRM drivers switched their > initialization code to set the GART/aperture size to 64MB (for PCI) or 512MB (for PCIE), > and the pci_is_pcie() function is used to determine if the graphics card is PCI or PCIE. > > Now my question: > My assumption is, that pci_is_pcie() should return true for PCI-E cards only. > PCI-only cards should return false. Is this assumption correct? Yes. > If yes, there is probably a bug somewhere and maybe someone here has an idea what I could test to fix this bug? > If not, then the nouveau and radeon drivers should not use pci_is_pcie() to determine if this is a PCI or PCI-E card... > > I did some testing with kernel 3.1.5. > For the nVidia card (PCI 01:00.0) I got: > - pci_is_pcie(dev->pdev) = 1 > - pci_find_capability(dev->pdev, PCI_CAP_ID_EXP) = 120 > > lspci output: > 00:00.0 Host bridge: Intel Corporation 4 Series Chipset DRAM Controller (rev 03) > 00:01.0 PCI bridge: Intel Corporation 4 Series Chipset PCI Express Root Port (rev 03) > 00:1b.0 Audio device: Intel Corporation N10/ICH 7 Family High Definition Audio Controller (rev 01) > 00:1c.0 PCI bridge: Intel Corporation N10/ICH 7 Family PCI Express Port 1 (rev 01) > 00:1c.1 PCI bridge: Intel Corporation N10/ICH 7 Family PCI Express Port 2 (rev 01) > 00:1d.0 USB Controller: Intel Corporation N10/ICH7 Family USB UHCI Controller #1 (rev 01) > 00:1d.1 USB Controller: Intel Corporation N10/ICH 7 Family USB UHCI Controller #2 (rev 01) > 00:1d.2 USB Controller: Intel Corporation N10/ICH 7 Family USB UHCI Controller #3 (rev 01) > 00:1d.3 USB Controller: Intel Corporation N10/ICH 7 Family USB UHCI Controller #4 (rev 01) > 00:1d.7 USB Controller: Intel Corporation N10/ICH 7 Family USB2 EHCI Controller (rev 01) > 00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev e1) > 00:1f.0 ISA bridge: Intel Corporation 82801GB/GR (ICH7 Family) LPC Interface Bridge (rev 01) > 00:1f.1 IDE interface: Intel Corporation 82801G (ICH7 Family) IDE Controller (rev 01) > 00:1f.2 IDE interface: Intel Corporation N10/ICH7 Family SATA IDE Controller (rev 01) > 01:00.0 VGA compatible controller: nVidia Corporation G72 [GeForce 7300 LE] (rev a1) > 02:00.0 Ethernet controller: Atheros Communications AR8121/AR8113/AR8114 Gigabit or Fast Ethernet (rev b0) > 04:01.0 VGA compatible controller: ATI Technologies Inc RV280 [FireMV 2200 PCI] (rev 01) > 04:01.1 Display controller: ATI Technologies Inc RV280 [FireMV 2200 PCI] (secondary) (rev 01) Can you send lspci -xxxxs01:00.0 lspci -xxxxs04:01.0 lspci -xxxxs04:01.1 (that is four 'x' characters). -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
