Hi Serge, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on robh/for-next linus/master v6.0-rc2 next-20220822] [cannot apply to krzk-dt/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/PCI-dwc-Add-generic-resources-and-Baikal-T1-support/20220823-025041 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-randconfig-a001-20220822 (https://download.01.org/0day-ci/archive/20220823/202208231433.fakKI8V3-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/224f55689ef22eddaeb641cf793de934a60e1be9 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Serge-Semin/PCI-dwc-Add-generic-resources-and-Baikal-T1-support/20220823-025041 git checkout 224f55689ef22eddaeb641cf793de934a60e1be9 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/pci/controller/dwc/pcie-designware-ep.c:734:28: error: use of undeclared identifier 'np' ret = of_property_read_u8(np, "max-functions", &epc->max_functions); ^ 1 error generated. vim +/np +734 drivers/pci/controller/dwc/pcie-designware-ep.c e966f7390da935 drivers/pci/controller/dwc/pcie-designware-ep.c Vidya Sagar 2020-02-17 678 e966f7390da935 drivers/pci/controller/dwc/pcie-designware-ep.c Vidya Sagar 2020-02-17 679 int dw_pcie_ep_init(struct dw_pcie_ep *ep) e966f7390da935 drivers/pci/controller/dwc/pcie-designware-ep.c Vidya Sagar 2020-02-17 680 { f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 681 int ret; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 682 void *addr; 47a062609a30d8 drivers/pci/controller/dwc/pcie-designware-ep.c Xiaowei Bao 2020-09-18 683 u8 func_no; a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 684 struct resource *res; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 685 struct pci_epc *epc; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 686 struct dw_pcie *pci = to_dw_pcie_from_ep(ep); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 687 struct device *dev = pci->dev; a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 688 struct platform_device *pdev = to_platform_device(dev); e966f7390da935 drivers/pci/controller/dwc/pcie-designware-ep.c Vidya Sagar 2020-02-17 689 const struct pci_epc_features *epc_features; 47a062609a30d8 drivers/pci/controller/dwc/pcie-designware-ep.c Xiaowei Bao 2020-09-18 690 struct dw_pcie_ep_func *ep_func; 47a062609a30d8 drivers/pci/controller/dwc/pcie-designware-ep.c Xiaowei Bao 2020-09-18 691 47a062609a30d8 drivers/pci/controller/dwc/pcie-designware-ep.c Xiaowei Bao 2020-09-18 692 INIT_LIST_HEAD(&ep->func_list); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 693 224f55689ef22e drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-08-22 694 ret = dw_pcie_get_resources(pci); 224f55689ef22e drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-08-22 695 if (ret) 224f55689ef22e drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-08-22 696 return ret; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 697 a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 698 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 699 if (!res) a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 700 return -EINVAL; a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 701 a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 702 ep->phys_base = res->start; a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 703 ep->addr_size = resource_size(res); a0fd361db8e508 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 704 13e9d3900c2024 drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-06-24 705 dw_pcie_version_detect(pci); 13e9d3900c2024 drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-06-24 706 e3dc79adfac96d drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-06-24 707 dw_pcie_iatu_detect(pci); e3dc79adfac96d drivers/pci/controller/dwc/pcie-designware-ep.c Serge Semin 2022-06-24 708 6be6f8529bd7f3 drivers/pci/controller/dwc/pcie-designware-ep.c Christophe JAILLET 2022-07-09 709 ep->ib_window_map = devm_bitmap_zalloc(dev, pci->num_ib_windows, ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 710 GFP_KERNEL); ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 711 if (!ep->ib_window_map) ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 712 return -ENOMEM; ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 713 6be6f8529bd7f3 drivers/pci/controller/dwc/pcie-designware-ep.c Christophe JAILLET 2022-07-09 714 ep->ob_window_map = devm_bitmap_zalloc(dev, pci->num_ob_windows, ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 715 GFP_KERNEL); ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 716 if (!ep->ob_window_map) ad4a5becc689c3 drivers/pci/dwc/pcie-designware-ep.c Niklas Cassel 2017-12-14 717 return -ENOMEM; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 718 9ca17af552bcd2 drivers/pci/controller/dwc/pcie-designware-ep.c Rob Herring 2020-11-05 719 addr = devm_kcalloc(dev, pci->num_ob_windows, sizeof(phys_addr_t), f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 720 GFP_KERNEL); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 721 if (!addr) f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 722 return -ENOMEM; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 723 ep->outbound_addr = addr; f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 724 f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 725 epc = devm_pci_epc_create(dev, &epc_ops); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 726 if (IS_ERR(epc)) { b4a8a51caf7de4 drivers/pci/dwc/pcie-designware-ep.c Gustavo Pimentel 2018-05-14 727 dev_err(dev, "Failed to create epc device\n"); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 728 return PTR_ERR(epc); f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 729 } f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 730 4e965ede1856ed drivers/pci/controller/dwc/pcie-designware-ep.c Gustavo Pimentel 2018-07-19 731 ep->epc = epc; 4e965ede1856ed drivers/pci/controller/dwc/pcie-designware-ep.c Gustavo Pimentel 2018-07-19 732 epc_set_drvdata(epc, ep); 4e965ede1856ed drivers/pci/controller/dwc/pcie-designware-ep.c Gustavo Pimentel 2018-07-19 733 f8aed6ec624fb4 drivers/pci/dwc/pcie-designware-ep.c Kishon Vijay Abraham I 2017-03-27 @734 ret = of_property_read_u8(np, "max-functions", &epc->max_functions); -- 0-DAY CI Kernel Test Service https://01.org/lkp
