On Fri, Aug 19, 2022 at 05:20:40PM +0200, Greg KH wrote: > On Fri, Aug 19, 2022 at 08:20:15PM +0530, Manivannan Sadhasivam wrote: > > IOCTLs are supposed to return 0 for success and negative error codes for > > failure. Currently, this driver is returning 0 for failure and 1 for > > success, that's not correct. Hence, fix it! > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > This needs to come first in the series, Yeah, I thought about that but then I had one more patch touching this driver and if this comes first then that patch should be at 4/5. I was not sure if that's fine since two patches touching the same driver would be at different positions in a series. Anyway, since you said, I'll just move this to 1/5 and other one to 4/5. > along with a Fixes: tag, and a > cc: stable tag so that it can be properly backported and fixed up > everywhere. > Okay. Thanks, Mani > thanks, > > greg k-h -- மணிவண்ணன் சதாசிவம்
