Re: [PATCH v6 5/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/17/2022 11:10 PM, Jason Gunthorpe wrote:
> On Wed, Aug 17, 2022 at 09:34:30PM +0530, Abhishek Sahu wrote:
>> On 8/17/2022 7:23 PM, Jason Gunthorpe wrote:
>>> On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:
>>>
>>>> +static int
>>>> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
>>>> +				   void __user *arg, size_t argsz)
>>>
>>> This should be
>>>   struct vfio_device_low_power_entry_with_wakeup __user *arg
>>>
>>
>>  Thanks Jason.
>>
>>  I can update this.
>>
>>  But if we look the existing code, for example
>>  (vfio_ioctl_device_feature_mig_device_state()), then there it still uses
>>  'void __user *arg' only. Is this a new guideline which we need to take
>>  care ?
> 
> I just sent a patch that fixes that too
> 

 Thanks for the update.
 I will change this. 

>>  Do we need to keep the IOCTL name alphabetically sorted in the case list.
>>  Currently, I have added in the order of IOCTL numbers.
> 
> It is generally a good practice to sort lists of things.
> 
> Jason

 Sure. I will make the sorted list.

 Regards,
 Abhishek



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux