On 11/08/2022 23:33, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> Upgrading dt-schema to v2022.08 reveals unevaluatedProperties issues
> that were not previously visible, such as the missing clocks and
> clock-names properties for PolarFire SoC's PCI controller:
> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: pcie@2000000000: Unevaluated properties are not allowed ('clock-names', 'clocks', 'legacy-interrupt-controller', 'microchip,axi-m-atr0' were unexpected)
> From schema: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
>
> The clocks are required to enable interfaces between the FPGA fabric
> and the core complex, so add them to the binding.
>
> Fixes: 6ee6c89aac35 ("dt-bindings: PCI: microchip: Add Microchip PolarFire host binding")
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
> .../bindings/pci/microchip,pcie-host.yaml | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> index edb4f81253c8..2a2166f09e2c 100644
> --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> @@ -25,6 +25,31 @@ properties:
> - const: cfg
> - const: apb
>
> + clocks:
> + description:
> + Fabric Interface Controllers, FICs, are the interface between the FPGA
> + fabric and the core complex on PolarFire SoC. The FICs require two clocks,
> + one from each side of the interface. The "FIC clocks" described by this
> + property are on the core complex side & communication through a FIC is not
> + possible unless it's corresponding clock is enabled. A clock must be
> + enabled for each of the interfaces the root port is connected through.
> + minItems: 1
> + items:
> + - description: FIC0's clock
> + - description: FIC1's clock
> + - description: FIC2's clock
> + - description: FIC3's clock
> +
> + clock-names:
> + items:
> + enum:
> + - fic0
> + - fic1
> + - fic2
> + - fic3
> + minItems: 1
> + maxItems: 4
No need for maxItems.
Best regards,
Krzysztof
