On Tue, Aug 09, 2022 at 11:29:43AM -0700, Stephen Hemminger wrote: > This commit broke the driver override script in DPDK. > This is an API/ABI breakage, please revert or fix the commit. > > Report of problem: > http://mails.dpdk.org/archives/dev/2022-August/247794.html > > > commit 23d99baf9d729ca30b2fb6798a7b403a37bfb800 > Author: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Date: Tue Apr 19 13:34:28 2022 +0200 > > PCI: Use driver_set_override() instead of open-coding > > Use a helper to set driver_override to the reduce amount of duplicated > code. Make the driver_override field const char, because it is not > modified by the core and it matches other subsystems. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Link: https://lore.kernel.org/r/20220419113435.246203-6-krzysztof.kozlowski@xxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > The script is sending single nul character to remove override > and that no longer works. > > Source code to dpdk-devbind > https://github.com/DPDK/dpdk/blob/main/usertools/dpdk-devbind.py Ah, that's messy. I'll try to fix up driver_override() to handle a \0 being sent as the string, we should treat that as an empty write. Let me think about that later today... thanks, greg k-h
