Yep, thanks. Applied.
Jesse
On Mon, 5 Dec 2011 18:12:28 +0100
Ingo Molnar <mingo@xxxxxxx> wrote:
>
> i think this would be yours? Wrong Cc:s it appears.
>
>
> I suspect the original 24d9b70b commit should have gone via the
> PCI tree too ...
>
> Thanks,
>
> Ingo
>
> ----- Forwarded message from Andreas Herrmann <herrmann.der.user@xxxxxxxxxxxxxx> -----
>
> Date: Fri, 2 Dec 2011 08:27:53 +0100
> From: Andreas Herrmann <herrmann.der.user@xxxxxxxxxxxxxx>
> To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, "H. Peter Anvin"
> <hpa@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx, Robert Richter <robert.richter@xxxxxxx>, Jan Beulich
> <jbeulich@xxxxxxxxxx>, Borislav Petkov <borislav.petkov@xxxxxxx>, Frank Arnold
> <frank.arnold@xxxxxxx>
> Subject: [PATCH] x86, amd: Kill misleading message about enablement of IO access to PCI ECS
>
> From: Andreas Herrmann <andreas.herrmann3@xxxxxxx>
>
> Commit 24d9b70b8c679264756a6980e668b96b3f964826 (x86: Use PCI method
> for enabling AMD extended config space before MSR method) added a
> message when IO access to PCI ECS was enabled via access to the NB_CFG
> PCI register. This can lead to a bogus message like
>
> [ 0.365177] Extended Config Space enabled on 0 nodes
>
> which is misleading because IO ECS access is subsequently enabled for
> AMD CPUs (that support this) by modifying the corresponding NB_CFG
> MSR.
>
> Furthermore it's not "Extended Config Space" that is enabled by this
> register setting. It's the IO access that is enabled for extended
> configruation space.
>
> IMHO the ambiguous message needs to be cancelled.
>
> Cc: Jan Beulich <jbeulich@xxxxxxxxxx>
> Cc: Robert Richter <robert.richter@xxxxxxx>
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@xxxxxxx>
> ---
> arch/x86/pci/amd_bus.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
> index 026e493..7b7a897 100644
> --- a/arch/x86/pci/amd_bus.c
> +++ b/arch/x86/pci/amd_bus.c
> @@ -403,7 +403,6 @@ static void __init pci_enable_pci_io_ecs(void)
> ++n;
> }
> }
> - pr_info("Extended Config Space enabled on %u nodes\n", n);
> #endif
> }
>
--
Jesse Barnes, Intel Open Source Technology Center
Attachment:
signature.asc
Description: PGP signature
