Jonathan Cameron wrote: > On Thu, 14 Jul 2022 17:02:41 -0700 > Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > > The region provisioning process involves allocating DPA to a set of > > endpoint decoders, and HPA plus the region geometry to a region device. > > Then the decoder is assigned to the region. At this point several > > validation steps can be performed to validate that the decoder is > > suitable to participate in the region. > > > > Co-developed-by: Ben Widawsky <bwidawsk@xxxxxxxxxx> > > Signed-off-by: Ben Widawsky <bwidawsk@xxxxxxxxxx> > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > I think you've lost some planned changes here as typos from v1 review > still here as is the stale comment. > > With those fixed > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > > index b1e847827c6b..871bfdbb9bc8 100644 > > --- a/drivers/cxl/core/region.c > > +++ b/drivers/cxl/core/region.c > > > +/* > > + * - Check that the given endpoint is attached to a host-bridge identified > > + * in the root interleave. > > In reply to v1 review I think you said you had dropped this comment as stale? Correct, its gone now along with some other 0day robot reported fixups: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/tree/drivers/cxl/core/region.c?h=preview#n1099