On Tue, Jul 19, 2022 at 07:32:46AM -0700, Christoph Hellwig wrote: > On Tue, Jul 19, 2022 at 10:05:46PM +0900, Stafford Horne wrote: > > > > Or we could try to keep the generic definition in a global header > > > > like linux/isa-dma.h. > > > > > > Perhaps option 3 makes the whole patch the most clean. > > > > And this is the result, I will get this into the series and create a v4 tomorrow > > if no issues. > > Yes, this is what I tried to suggest earlier and it looks fine to me. > If we want to overengineer it we could add a ISA_DMA_BRIDGE_BUGGY > Kconfig symbol and select it from x86. I left it as X86_32, I feel it it would be more confusing/hard to maintain to add the extra level of indirection. -Stafford