On Mon, Jul 11, 2022 at 05:29:59PM -0500, Bjorn Helgaas wrote: > On Fri, Jul 01, 2022 at 11:25:18AM +0800, Richard Zhu wrote: > > ... > > Bjorn Helgaas (5): > > PCI: imx6: Move imx6_pcie_grp_offset(), imx6_pcie_configure_type() > > earlier > > PCI: imx6: Move PHY management functions together > > PCI: imx6: Move imx6_pcie_enable_ref_clk() earlier > > PCI: imx6: Factor out ref clock disable to match enable > > PCI: imx6: Disable clocks in reverse order of enable > > > > Richard Zhu (12): > > PCI: imx6: Move imx6_pcie_clk_disable() earlier > > PCI: imx6: Collect clock enables in imx6_pcie_clk_enable() > > PCI: imx6: Propagate .host_init() errors to caller > > PCI: imx6: Disable i.MX6QDL clock when disabling ref clocks > > PCI: imx6: Call host init function directly in resume > > PCI: imx6: Turn off regulator when system is in suspend mode > > PCI: imx6: Move regulator enable out of > > imx6_pcie_deassert_core_reset() > > PCI: imx6: Mark the link down as non-fatal error > > PCI: imx6: Reduce resume time by only starting link if it was up > > before suspend > > PCI: imx6: Do not hide phy driver callbacks and refine the error > > handling > > PCI: imx6: Reformat suspend callback to keep symmetric with resume > > PCI: imx6: Move the imx6_pcie_ltssm_disable() earlier > > > > drivers/pci/controller/dwc/pci-imx6.c | 661 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------- > > 1 file changed, 358 insertions(+), 303 deletions(-) > > Applied to pci/ctrl/imx6 for v5.20, thanks a lot for all your work > here! I updated the branch with Lucas' acks and with the minor imx6_pcie_start_link() return value check he suggested. I did not do anything about the missing IMX8MQ case in imx6_pcie_ltssm_disable() or the PHY init or regulator or shutdown issues. If you want changes there, please make them starting with the pci/ctrl/imx6 branch and I can just replace it: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ctrl/imx6&id=7d652ce95e70 Bjorn