Hi Jesse,
Any comment on that patch ?
On Wed, Sep 21, 2011 at 11:29, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>
> On Wednesday, September 21, 2011, Vincent Palatin wrote:
> > When the runtime PM is activated on PCI, if a device switches state frequently
> > (e.g. an EHCI controller with autosuspending USB devices connected)
> > the PCI configuration traces might be very verbose in the kernel log.
> > Let's guard those traces with DEBUG condition.
> >
> > Signed-off-by: Vincent Palatin <vpalatin@xxxxxxxxxxxx>
>
> Acked-by: Rafael J. Wysocki <rjw@xxxxxxx>
>
> > ---
> > arch/x86/pci/i386.c | 2 +-
> > drivers/acpi/pci_irq.c | 10 +++++-----
> > drivers/pci/pci.c | 5 ++---
> > drivers/pci/setup-res.c | 6 +++---
> > 4 files changed, 11 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
> > index 494f2e7..eb5d20b 100644
> > --- a/arch/x86/pci/i386.c
> > +++ b/arch/x86/pci/i386.c
> > @@ -269,7 +269,7 @@ void pcibios_set_master(struct pci_dev *dev)
> > lat = pcibios_max_latency;
> > else
> > return;
> > - dev_printk(KERN_DEBUG, &dev->dev, "setting latency timer to %d\n", lat);
> > + dev_dbg(&dev->dev, "setting latency timer to %d\n", lat);
> > pci_write_config_byte(dev, PCI_LATENCY_TIMER, lat);
> > }
> >
> > diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> > index 7f9eba9..0eefa12 100644
> > --- a/drivers/acpi/pci_irq.c
> > +++ b/drivers/acpi/pci_irq.c
> > @@ -487,10 +487,10 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
> > else
> > link_desc[0] = '\0';
> >
> > - dev_info(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",
> > - pin_name(pin), link_desc, gsi,
> > - (triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",
> > - (polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
> > + dev_dbg(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",
> > + pin_name(pin), link_desc, gsi,
> > + (triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",
> > + (polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
> >
> > return 0;
> > }
> > @@ -524,6 +524,6 @@ void acpi_pci_irq_disable(struct pci_dev *dev)
> > * (e.g. PCI_UNDEFINED_IRQ).
> > */
> >
> > - dev_info(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));
> > + dev_dbg(&dev->dev, "PCI INT %c disabled\n", pin_name(pin));
> > acpi_unregister_gsi(gsi);
> > }
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 0ce6742..d339c30 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -964,7 +964,7 @@ void pci_restore_state(struct pci_dev *dev)
> > for (i = 15; i >= 0; i--) {
> > pci_read_config_dword(dev, i * 4, &val);
> > if (val != dev->saved_config_space[i]) {
> > - dev_printk(KERN_DEBUG, &dev->dev, "restoring config "
> > + dev_dbg(&dev->dev, "restoring config "
> > "space at offset %#x (was %#x, writing %#x)\n",
> > i, val, (int)dev->saved_config_space[i]);
> > pci_write_config_dword(dev,i * 4,
> > @@ -1531,8 +1531,7 @@ void pci_pme_active(struct pci_dev *dev, bool enable)
> > }
> >
> > out:
> > - dev_printk(KERN_DEBUG, &dev->dev, "PME# %s\n",
> > - enable ? "enabled" : "disabled");
> > + dev_dbg(&dev->dev, "PME# %s\n", enable ? "enabled" : "disabled");
> > }
> >
> > /**
> > diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> > index 51a9095..3878fe9 100644
> > --- a/drivers/pci/setup-res.c
> > +++ b/drivers/pci/setup-res.c
> > @@ -84,9 +84,9 @@ void pci_update_resource(struct pci_dev *dev, int resno)
> > }
> > }
> > res->flags &= ~IORESOURCE_UNSET;
> > - dev_info(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",
> > - resno, res, (unsigned long long)region.start,
> > - (unsigned long long)region.end);
> > + dev_dbg(&dev->dev, "BAR %d: set to %pR (PCI address [%#llx-%#llx])\n",
> > + resno, res, (unsigned long long)region.start,
> > + (unsigned long long)region.end);
> > }
> >
> > int pci_claim_resource(struct pci_dev *dev, int resource)
> >
>
--
Vincent
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
