Am Freitag, dem 01.07.2022 um 11:25 +0800 schrieb Richard Zhu: > Call imx6_pcie_host_init() instead of duplicating codes in resume. > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> So this isn't strictly a de-duplication, as imx6_pcie_host_init also does the MPLL setup again on i.MX6SX. Which I believe is absolutely the right thing to do in resume, even though I'm not aware of any system that would be affected by this change. Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > --- > drivers/pci/controller/dwc/pci-imx6.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index eaae144db4f3..2b42c37f1617 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1034,9 +1034,9 @@ static int imx6_pcie_resume_noirq(struct device *dev) > if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_SUPPORTS_SUSPEND)) > return 0; > > - imx6_pcie_assert_core_reset(imx6_pcie); > - imx6_pcie_init_phy(imx6_pcie); > - imx6_pcie_deassert_core_reset(imx6_pcie); > + ret = imx6_pcie_host_init(pp); > + if (ret) > + return ret; > dw_pcie_setup_rc(pp); > > ret = imx6_pcie_start_link(imx6_pcie->pci);
